Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds assist for basic Flutter Builder #45656

Closed
wants to merge 3 commits into from
Closed

Conversation

b-stime
Copy link
Contributor

@b-stime b-stime commented Apr 11, 2021

Fixes issues such as

Essentially, in Flutter, it's often useful to create a new context in the UI/widget tree as a place to begin a search towards the trunk of the tree for various state structures attached to lower levels of the tree. The basic Builder widget is the official means for creating such a context/entry-point.

The patches in this PR are essentially a copy-paste-tweak from two types of existing, similar assists. The main origin was taken from FlutterWrapStreamBuilder which wraps client code with a constructor for the StreamBuilder sub-class. The new assist, provided here, is a little more basic/general than the StreamBuilder so it was able to also adopt assertion and test code from some of the other assists for basic widgets.

@google-cla
Copy link

google-cla bot commented Apr 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 11, 2021
@b-stime
Copy link
Contributor Author

b-stime commented Apr 11, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 11, 2021
@bwilkerson
Copy link
Member

Thanks for the contribution! The review will happen at https://dart-review.googlesource.com/c/sdk/+/194941. You can continue to make changes to the PR (if any are needed) and push them to this site, and they will automatically be mirrored to Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants