Replace flutter/plugins analysis #51494
Conversation
Replaces the flutter/plugns with analysis of flutter/packages, now that flutter/plugins has been merged into flutter/packages and will no longer be updated. Also switches to calling the tool script directly, since the wrapper uses branch-based behavior that is no longer correct for this usage. This version matches the invocation used in flutter/flutter, so breakage due to repo changes is unlikely.
|
|
||
| # validate the tool's source | ||
| (cd script/tool; dart pub get) | ||
| (cd script/tool; dart analyze --fatal-infos) | ||
|
|
||
| # Invoke the repo's analysis script. | ||
| ./script/tool_runner.sh analyze \ | ||
| dart run script/tool/bin/flutter_plugin_tools.dart analyze \ |
There was a problem hiding this comment.
If we have any issues with this in the future, I'll create a custom wrapper called something like script/out_of_repo_analysis.sh, and update here and flutter/flutter to use it.
|
Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/284741 Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review. |
|
https://dart-review.googlesource.com/c/sdk/+/284741 has been updated with the latest commits from this pull request. |
Replaces the flutter/plugns with analysis of flutter/packages, now that flutter/plugins has been merged into flutter/packages and will no longer be updated.
Also switches to calling the tool script directly, since the wrapper uses branch-based behavior that is no longer correct for this usage. This version matches the invocation used in flutter/flutter, so breakage due to repo changes is unlikely.