Some work on the issue #40614 now that we have soundness #52383
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/303161 Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review. |
|
Thanks for the contribution @MelbourneDeveloper; submitting this to the queue now! |
|
@mit-mit thanks Michael. There are several other cases of this throughout the codebase so I plan to submit some more. |
This reverts commit e43939d. Reason for revert: It causes issues when applications are run with the --no-sound-null-safety flag. Original change's description: > Some work on the issue #40614 now that we have soundness > > Closes #52383 > > GitOrigin-RevId: 70014d0 > Change-Id: Ibf4ad3d862b07873317785389799ee8dfc80290f > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303161 > Reviewed-by: Siva Annamalai <asiva@google.com> > Commit-Queue: Michael Thomsen <mit@google.com> Change-Id: I9c928f6c6756c4aad22f1b98e86e9b04af999e7a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305040 Commit-Queue: Siva Annamalai <asiva@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
|
FYI – this was reverted, sadly. |
|
@kevmoo understandable. |
|
I'm hopeful that we can get this relanded in a few quarters, but yeah looks like we'll have to wait a bit. Sorry @MelbourneDeveloper. |
The Dart codebase has a bunch of TODOs for issue #40614. This PR removes a few of them.
It appears that the codebase used to require null guards, but now that Dart 3 has full null soundness, these calls are redundant.
Contribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.