Document that writeAsBytes truncates values beyond 0..255 #53782
Conversation
I just ran into this myself, no sense in anyone else having to hit this issue again.
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/330944 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
Potentially could also point to https://api.flutter.dev/flutter/dart-typed_data/ByteData-class.html for handling multi-byte values. |
|
The last sentence could be skipped or converted to hex, e.g. For example, |
|
(review comments from @lrhn are available in Gerrit) |
|
More trouble than it's worth to finish, closing. |
|
I'll land this for you sometime next week. |
|
Kind of you. Sorry to not follow through.
…On Fri, Nov 3, 2023 at 5:53 PM Brian Quinlan ***@***.***> wrote:
I'll land this for you sometime next week.
—
Reply to this email directly, view it on GitHub
<#53782 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADU2TNZK6J6ZKS6GPCSROTYCWGYJAVCNFSM6AAAAAA6EMFHFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGI3TMNRZGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Closes #53782 GitOrigin-RevId: 5453268 Change-Id: I7804cbe65c93bc34f56db6da7bc68aa1ef4e9303 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330944 Commit-Queue: Brian Quinlan <bquinlan@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com>
I just ran into this myself, no sense in anyone else having to hit this issue again.
Contribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.