Add missing #include <cstdlib> #53908
Conversation
A recent patch to libc++ (llvm/llvm-project@a65070a) removed some transitive includes, which causes build failures when using libc++ at HEAD. In particular, this file uses `std::free` without including `<cstdlib>`: error: missing '#include <cstdlib>'; 'free' must be declared before it is used 592 | typedef std::unique_ptr<char, decltype(std::free)*> CStringUniquePtr;
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/332452 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/332452 has been updated with the latest commits from this pull request. |
A recent patch to libc++ (llvm/llvm-project@a65070a) removed some transitive includes, which causes build failures when using libc++ at HEAD. In particular, this file uses
std::freewithout including<cstdlib>:Relevant issue: b/308435622