-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.1 seems to have introduced breaking changes #307
Comments
Do you mind posting the analysis issue you see? |
Thanks for the report! It looks like the port to package:web was unintentionally a breaking API change. This should have been done in a new major version of this package ( |
I'm going to close this as the issue has mostly been addressed. If people find new breaking changes please re-open or create a new issue. |
Thanks for addressing this so quickly! |
I've noticed that my package which depends on
web_socket_channel
suddenly has a "Analysis Issue" in pub.dev (https://pub.dev/packages/stomp_dart_client/score). This seems to be because of a breaking change introduced in 2.4.1. The change in question seems to be a move to theweb
package for the HTML WebSocket implementation.Here is part of my code which is breaking because of that:
Previously
HtmlWebSocketChannel
was expecting aWebSocket
from thedart:html
library. After 2.4.1 it seems to be expecting it from thepackage:web
package.Was this intentional? I am a bit hesitant to also move my project to the
web
package since it currently is still flagged as "highly experimental" (https://github.com/dart-lang/web)Related closed issue in the pub.dev repo: dart-lang/pub-dev#7327
The text was updated successfully, but these errors were encountered: