FrontendServerAssetReader #871
Conversation
dwds/CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## 1.0.0-dev | |||
|
|
|||
| - Remove dependency on `package:build_daemon`. | |||
| - Add 'FrontendServerAssetReader` for use with Frontend Server builds. | |||
|
|
||
| bool _haveReadOriginals = false; | ||
|
|
||
| /// Creates a `FrotnendServerAssetReader`. |
There was a problem hiding this comment.
[FrontendServerAssetReader]
| _jsonIncremental = File('$outputPath.incremental.json'); | ||
|
|
||
| @override | ||
| Future<String> dartSourceContents(String serverPath) => |
There was a problem hiding this comment.
This is actually interesting..... this wouldn't be anything specific to the frontend_server.
At the same time we will want an identical abstraction to this one which knows how to serve the JS files.
This class should probably extend an abstract DartSourceAssetReader blass which reads from the FS using a package resolver.
And then this file should also add an additional jsFileContents(String serverPath) method which we can plug into our server in webdev.
There was a problem hiding this comment.
Not sure we want to go with the base class approach. I think we'd want to delegate to a DartSourceAssetReader or something. I'll cross that hump when I get there though.
| Future<void> updateCaches() async { | ||
| if (!_haveReadOriginals) { | ||
| await _updateCaches(_mapOriginal, _jsonOriginal); | ||
| _haveReadOriginals = true; |
| } | ||
|
|
||
| Future<void> _updateCaches(File map, File json) async { | ||
| if (!(await map.exists() && await json.exists())) return; |
There was a problem hiding this comment.
We should consider throwing here (or logging an error at least)
| File mapOriginal; | ||
|
|
||
| Future<void> _createTempFixtures() async { | ||
| var fixtures = p.absolute(p.relative('test/fixtures', from: p.current)); |
There was a problem hiding this comment.
You shouldn't need any of the p.absolute(p.relative( here. But you should do p.join('test', 'fixtures').
There was a problem hiding this comment.
I think that is required for Windows testing? It's the pattern we do for the other fixtures, hence why I copied it.
There was a problem hiding this comment.
It shouldn't be necessary, this is just getting passed to a normal File constructor.
FrontendServerAssetReaderfor use with the Frontend ServerTowards #865