Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

API docs link broken on downloads archive page for stable 1.13.0 #1528

Closed
sebe opened this issue Nov 21, 2015 · 8 comments
Closed

API docs link broken on downloads archive page for stable 1.13.0 #1528

sebe opened this issue Nov 21, 2015 · 8 comments
Assignees
@whesse

Comments

@sebe
Copy link
Contributor

sebe commented Nov 21, 2015

API Doc link is broken for stable channel 1.13.0 and for dev since 1.13.0-dev.5.0
https://www.dartlang.org/downloads/archive/

In 1.12.2 there are two zip files a dart-api-docs.zip (4.9M) and dartdocs-gen-api.zip (37.2M) in the api-docs directory. http://gsdview.appspot.com/dart-archive/channels/stable/release/1.12.2/api-docs/

Now in the stable 1.13.0 the api-docs is a file link "api-docs 18-Nov-2015 22:52 46.1M"
A solution would be just to put the dartdocs-gen-api.zip file under an api-docs directory again, download_archive.dart is looking for doc zip at 'api-docs/dartdocs-gen-api.zip'.
@mit-mit
Copy link
Contributor

mit-mit commented Nov 23, 2015

@whesse, can you take a look please?

@whesse
Copy link
Contributor

whesse commented Nov 23, 2015

@keertip Is this intended, that we are publishing the docs in a different format? I'll look at when the change happened, to see what caused it.

@sebe
Copy link
Contributor Author

sebe commented Nov 26, 2015

While working out the cause, getting the website link to work would be good.
Could you not fix this problem for current release, 1.13.0, api docs by renaming the file api-docs to dartdocs-gen-api.zip, then create the api-docs directory and move the dartdocs-gen-api.zip under the api-docs directory?

@whesse
Copy link
Contributor

whesse commented Nov 26, 2015

Yes, I'll work on fixing it that way.

@whesse
Copy link
Contributor

whesse commented Nov 27, 2015

The download link on dartlang.org is now working, for 1.13.0. We still need to verify that the zip file downloaded is correct when unzipped, and works like the old one.

We also need to fix the script that is putting the zip file in the incorrect place. I think someone is just trying to copy to that directory, not realizing that directories don't really exist in cloud storage, and if the directory doesn't exist, it moves a file to that name.

@sebe
Copy link
Contributor Author

sebe commented Nov 28, 2015

Looks OK.
I unzip the file and it's the api ref for "Dart SDK 1.13.0", version is at the bottom of the page.
It's the same as https://api.dartlang.org/1.13.0/index.html , except the search box is not working, this is this is also the case for previous release "Dart SDK 1.12.2".

@whesse
Copy link
Contributor

whesse commented Dec 7, 2015

My change to the promote script to copy the whole api directory is broken, when there is only one file in the source directory that we copy to the target. Reverting it, so we just copy the one file to the new location, in https://codereview.chromium.org/1502253002/

Running the new script leaves the old file there with the "api-docs" name, so we have both an "api-docs" file and an "api-docs" directory. Deleting the file by hand.

whesse added a commit to dart-lang/sdk that referenced this issue Dec 9, 2015
@whesse
Revert "Copy entire api-docs directory to release GCloud directory in…
ed9bb16 
… promote script."

This reverts commit f03279a.
When there is only one file in the directory, this does not move the
file into the target directory, but moves it to replace the target
directory with a file.

Reverting to the old behavior, with a changed filename, since we are
now only copying one file. tools/bots/bot_utils.py:124 is changed to
use dartdocs_zipfilename() instead of the deleted apidocs_zipfilename().

BUG=dart-archive/www.dartlang.org#1528
R=ricow@google.com

Review URL: https://codereview.chromium.org/1502253002 .
@Sfshaza Sfshaza self-assigned this Jul 21, 2016
@Sfshaza
Copy link
Contributor

Sfshaza commented Jul 21, 2016

I spent a lot of time fixing the links to the API docs on the new sites. Closing.

@Sfshaza Sfshaza closed this as completed Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@whesse whesse

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sebe @whesse @Sfshaza @mit-mit