-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the existing screenshot example to multi display example #704
Conversation
example/screenshot.dart
Outdated
GetClientRect(hwnd, rcClient); | ||
class Display { | ||
final String rawName; | ||
final bool isTurnOn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the name active
instead:
final bool isTurnOn; | |
final bool active; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, isTurnOn
sounds more expressive.
It might be better to call isConnected
as @tbsmanish asked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @ilopX! A couple of other minor suggestions here. Happy to make the changes if you don't have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks so much, @ilopX!
Discussion: https://github.com/orgs/dart-windows/discussions/603#discussioncomment-5908035