Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self collision does not work properly for tree structure #125

Closed
jslee02 opened this issue Dec 12, 2013 · 2 comments
Closed

Self collision does not work properly for tree structure #125

jslee02 opened this issue Dec 12, 2013 · 2 comments
Labels
priority: high should be resolved right now type: bug Indicates an unexpected problem or unintended behavior

Comments

@jslee02
Copy link
Member

jslee02 commented Dec 12, 2013

For example, if we test self collision with hand like structure, the contact handling does not work properly when two fingers are colliding.

@karenliu
Copy link
Member

The bug was in UpdateNBMatrices(). When there is a self collision, the two colliding bodies fill in the same block of matrix N and matrix B. In the original code, body 2 will override body 1's value. To fix the bud, we only need to modify "=" to "+=" when updating body 2's block.

@jslee02
Copy link
Member Author

jslee02 commented Dec 16, 2013

This bug is fixed at master branch (a696486) and release-3.0 branch (3de01ab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high should be resolved right now type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants