Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature-toggles): remove remnants of feature toggles (DEV-217) #2176

merged 12 commits into from Aug 26, 2022


Copy link

@irinaschubert irinaschubert commented Aug 25, 2022

Resolves DEV-217

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-217

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Aug 25, 2022
@irinaschubert irinaschubert marked this pull request as ready for review August 25, 2022 11:00
Copy link

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just maybe the class OldListsRouteADMFeature could be adjusted in this PR too, or moved to another issue, due to fact all lists methods are stored in 3 instead of 1 file.

@subotic subotic merged commit ed1cbd0 into main Aug 26, 2022
9 checks passed
@subotic subotic deleted the wip/dev-217-remove-feature-toggles branch August 26, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants