Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify :full_outer v :outer joins #81

Closed
asummers opened this issue Apr 27, 2019 · 1 comment
Closed

Clarify :full_outer v :outer joins #81

asummers opened this issue Apr 27, 2019 · 1 comment

Comments

@asummers
Copy link
Contributor

asummers commented Apr 27, 2019

In investigating the Dialyzer errors (see also #80), I found that flow.ex operates on join of both :outer and :full_outer. The docs and the usage in Flow.Materialize and the tests suggest it should be :full_outer but the there are uses of :outer in the @join module attribute and the @type join, as well as several function calls. Which of these is actually intended?

Additionally, the typespec for @typep producers needs to be | {:join, join, t, t, fun(), fun(), fun()} with the join as the second argument. Whenever the :full_outer v :outer is resolved, and this is added, that section of the errors will disappear.

@josevalim
Copy link
Member

Good catch. The join one is full_outer. The other :outer is unrelated. Thanks for all fo the fixes!

josevalim pushed a commit that referenced this issue Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants