Begin fixing Dialyzer errors. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asummers
force-pushed
the
partially-fix-types
branch
from
384cc47
to
9c0f676
Compare
This was referenced Apr 27, 2019
asummers
changed the title
asummers
force-pushed
the
partially-fix-types
branch
from
da43105
to
0ab7cbf
Compare
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still several errors in
flow.exthat I have not figured out yet, so I am uncomfortable adding Dialyzer to the travis script.Basically, all the
Flow.Window.count,bounded_joinandwindowed_joinand friends have extra keys that were not reflected inFlow.Window.t()which caused downstream Dialyzer errors whenever these functions are used.