This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
fix: waitForTransactionToBeProvable not waiting for blocks
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Feb 9, 2021
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
lib/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Feb 9, 2021
shumkov
changed the title
BlockchainListener#waitForBlocks not waiting for blocks properly
shumkov
changed the title
BlockchainListener#waitForBlocks not waiting for blocks properlywaitForBlocks not waiting for blocks properly
shumkov
reviewed
Feb 9, 2021
|
This pull request introduces 2 alerts when merging 53f5dc2 into 482617d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e22be10 into 482617d - view on LGTM.com new alerts:
|
# Conflicts: # lib/externalApis/tenderdash/blockchainListener/BlockchainListener.js # lib/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
|
This pull request introduces 1 alert when merging 4be94d1 into 482617d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7bf04fe into 482617d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6113024 into 482617d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 68d082b into 482617d - view on LGTM.com new alerts:
|
shumkov
changed the title
waitForBlocks not waiting for blocks properlywaitForTransactionToBeProvable not waiting for blocks properly
shumkov
changed the title
waitForTransactionToBeProvable not waiting for blocks properlywaitForTransactionToBeProvable not waiting for blocks
jawid-h
approved these changes
Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Fix
BlockchainListener#waitForBlocksnot waiting for blocks properly. It wasn't uncovered due to another bug in the drive that was fixed in dashevo/js-drive#457What was done?
waitForBlocksmethod ofBlockchainListenerto subscribe to all needed block events at the same time and not one by oneHow Has This Been Tested?
With tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only