Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate)!: build DAPI and Drive from monorepo path #145

Merged
merged 8 commits into from
Dec 22, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Dec 21, 2021

Issue being fixed or feature implemented

DAPI and Drive docker images require the whole monorepo to build due to dependencies so there is no point to have two separate paths in dashmate.

What was done?

  • Introduce platform.sourcePath instead of platform.drive.abci.docker.build.path and platform.dapi.api.docker.build.path

How Has This Been Tested?

With CI

Breaking Changes

platform.drive.abci.docker.build.path and platform.dapi.api.docker.build.path are removed in favor of platform.sourcePath

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.22-dev to master December 21, 2021 11:46
@shumkov shumkov changed the title feat: publish dashmate to NPM feat(dashmate): build DAPI and Drive from the project source path Dec 22, 2021
@shumkov shumkov changed the title feat(dashmate): build DAPI and Drive from the project source path feat(dashmate): build DAPI and Drive from monorepo path Dec 22, 2021
@shumkov shumkov added this to the v0.21.x milestone Dec 22, 2021
@shumkov shumkov marked this pull request as ready for review December 22, 2021 05:44
@shumkov shumkov changed the title feat(dashmate): build DAPI and Drive from monorepo path feat(dashmate)!: build DAPI and Drive from monorepo path Dec 22, 2021
Copy link
Collaborator

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@shumkov shumkov merged commit 8e7a203 into master Dec 22, 2021
@shumkov shumkov deleted the publish-dashmate branch December 22, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants