Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dpp): grpc common bootstrap not working #16

Merged
merged 1 commit into from
Nov 4, 2021
Merged

test(dpp): grpc common bootstrap not working #16

merged 1 commit into from
Nov 4, 2021

Conversation

antouhou
Copy link
Collaborator

@antouhou antouhou commented Nov 4, 2021 •
edited by shumkov
Loading

Issue being fixed or feature implemented

Mocha bootstrap not working due to updated version of mocha

What was done?

Updated mocha config to the latest standard

How Has This Been Tested?

Run tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou changed the base branch from v0.22-dev to master November 4, 2021 13:57
@shumkov shumkov added this to the v0.21.x milestone Nov 4, 2021
shumkov
shumkov approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title fix(dpp): grpc common bootstrap not working tests(dpp): grpc common bootstrap not working Nov 4, 2021
@shumkov shumkov changed the title tests(dpp): grpc common bootstrap not working test(dpp): grpc common bootstrap not working Nov 4, 2021
@shumkov shumkov merged commit 361a6a0 into master Nov 4, 2021
@shumkov shumkov deleted the fix-grpc-common-bootstrap branch November 4, 2021 14:12
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@QuantumExplorer
Merge pull request #16 from PastaPastaPasta/lots-of-warnings
4e46662 
refactor: fix lots of warnings
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@antouhou
Merge pull request #16 from dashevo/feat-key-and-identity-deser
526d793 
feat: correct CBOR serialization and deserialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@shumkov shumkov shumkov approved these changes

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
3 participants
@antouhou @shumkov @shuplenkov