feat: masternode reward shares contract #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 27, 2021 15:03
shumkov
changed the title
shumkov
reviewed
Dec 28, 2021
added 4 commits
December 28, 2021 19:30
# Conflicts: # .pnp.cjs # packages/dashmate/configs/migrations.js # packages/dashmate/configs/schema/configJsonSchema.js # packages/dashmate/configs/system/base.js # yarn.lock
shumkov
reviewed
Dec 29, 2021
shumkov
reviewed
Dec 29, 2021
shumkov
reviewed
Dec 29, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 29, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Show resolved
Hide resolved
shumkov
reviewed
Dec 29, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 29, 2021
shumkov
reviewed
Dec 29, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Show resolved
Hide resolved
shumkov
reviewed
Dec 29, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
shumkov
reviewed
Dec 31, 2021
...es/js-dpp/lib/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.js
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
shumkov
reviewed
Dec 31, 2021
packages/masternode-reward-shares-contract/schema/reward-share-documents.json
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
...est/unit/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.spec.js
Outdated
Show resolved
Hide resolved
jawid-h
approved these changes
Jan 5, 2022
shumkov
changed the title
thephez
reviewed
Jan 5, 2022
| @@ -0,0 +1,33 @@ | |||
| # Reward sharing Contract | |||
|
|
|||
| [](https://github.com/dashevo/dpns-contract/actions/workflows/test_and_release.yml) | |||
There was a problem hiding this comment.
Just noticed the badges, description, and install command all refer to the DPNS contract, not reward sharing.
There was a problem hiding this comment.
Too late :( could you please create one more PR to fix it?
There was a problem hiding this comment.
Actually it appears nothing is published on npm so they would just be broken links. Probably should update at release? This also reveals the larger issue that all build status and release badges in this repo need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Share rewards with other identities
What was done?
How Has This Been Tested?
With unit and integration tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only