Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-lib): added WalletStore #197

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

Alex-Werner
Copy link
Contributor

Issue being fixed or feature implemented

In dashevo/wallet-lib#351, we introduced multiple features that couldn't be managed as is due to its size.
This PR is the least minimal of them concerning WalletStore (excluding the connection to Wallet-lib) itself.

What was done?

  • feat: introduced WalletStore

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner changed the title feat: added WalletStore feat(wallet-lib): added WalletStore Jan 19, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Alex-Werner Alex-Werner merged commit 44083bc into v0.22-dev Jan 19, 2022
@Alex-Werner Alex-Werner deleted the feat/walletstore branch January 19, 2022 19:56
@shumkov shumkov added this to the v0.22.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants