-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: cache native npm modules during docker build #20
Conversation
Can we run this a few times to test setup times in CI? I think we will still need to remove |
@strophy yeah, I ran it many times and if everything is cached it takes seconds to build. I've updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome fix! 🥇
…lidation feat: documents batch transition - stateless validation
Issue being fixed or feature implemented
There are packages that uses node gyp to build native modules. It takes decent amount of time. Previously we had a solution to cache results: https://github.com/frangio/node-gyp-cache
After migration to monorepo, Node 16 and NPM 8, this solution doesn't work anymore.
What was done?
dashd-zmq-client
from DriveHow Has This Been Tested?
Running manually
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only