Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drive)!: allow to use range operators only in last where condition #201

Merged
merged 5 commits into from
Jan 19, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Jan 19, 2022

Issue being fixed or feature implemented

Due to GroveDB technical limitations, we can allow using range operators (in, 'startsWith', <, >, <=, >=) only for the last indexed property.

What was done?

  • updated validateQuery

How Has This Been Tested?

Unit tests

Breaking Changes

Some existing queries won't be valid

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov previously approved these changes Jan 19, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit c29d2fc into v0.22-dev Jan 19, 2022
@shumkov shumkov deleted the feat/in-clause-last branch January 19, 2022 19:54
@shumkov shumkov changed the title feat(drive): allow using in and startsWith only in last where condition feat(drive): allow to use range operators only in last where condition Jan 20, 2022
@shumkov shumkov changed the title feat(drive): allow to use range operators only in last where condition feat(drive)!: allow to use range operators only in last where condition Jan 20, 2022
@shumkov shumkov added this to the v0.22.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants