Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashmate): reset command doesn't work if setup failed #23

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(dashmate): reset command doesn't work if setup failed #23

merged 1 commit into from
Nov 8, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 8, 2021

Issue being fixed or feature implemented

Reset command doesn't work properly if setup command failed

What was done?

  • Store configs and default config on very end of setup
  • Remove generated configs on hard reset

How Has This Been Tested?

Running manually

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.x milestone Nov 8, 2021
@shumkov shumkov requested a review from strophy November 8, 2021 14:26
@shumkov shumkov merged commit 827b9ba into master Nov 8, 2021
@shumkov shumkov deleted the fix-reset-command branch November 8, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antouhou antouhou antouhou approved these changes

@strophy strophy Awaiting requested review from strophy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @antouhou