Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): add an ability to configure node subnet mask #237

Merged
merged 8 commits into from
Feb 6, 2022
Merged

feat(dashmate): add an ability to configure node subnet mask #237

merged 8 commits into from
Feb 6, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Feb 6, 2022 •
edited
Loading

Issue being fixed or feature implemented

Under linux running a VPN service network could not be created due to IPv4 address conflicts. This PR aims to add an ability to specify subnet mask for a default Docker network for each node.

What was done?

  • updated docker-compose.yml to use env variable for default network subnet
  • updated config templates

How Has This Been Tested?

Local setup

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h changed the title fix: network could not be created under linux running VPN service feat(dashmate): add an ability to configure node subnet mask Feb 6, 2022
shumkov
shumkov requested changes Feb 6, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement migration

@jawid-h jawid-h requested a review from shumkov February 6, 2022 11:58
@jawid-h @shumkov
Update packages/dashmate/configs/migrations.js
f437db1 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
shumkov
shumkov approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jawid-h jawid-h merged commit 5d292a5 into v0.22-dev Feb 6, 2022
@jawid-h jawid-h deleted the fix/linux-vpn-network branch February 6, 2022 12:31
@thephez thephez added this to the v0.22.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shumkov @thephez