Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): rimraf module could not remove config directory #248

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Feb 16, 2022

Issue being fixed or feature implemented

rimraf module could not remove non-empty directory during start, leading to:
Error: ENOTEMPTY: directory not empty, rmdir '<userdir>/.dashmate/local_1/logs' Code: ENOTEMPTY

Partially fixes this issue

What was done?

  • used fs.rmSync instead

How Has This Been Tested?

local setup

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov previously approved these changes Feb 16, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's remove rimraf in favor of rmSync recursive from other packages?

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 1ba3508 into v0.22-dev Feb 24, 2022
@shumkov shumkov deleted the fix/rimraf branch February 24, 2022 16:52
@thephez thephez added this to the v0.22.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rm drive_json.log: Permission denied
3 participants