-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashmate): rimraf
module could not remove config directory
#248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's remove rimraf
in favor of rmSync
recursive from other packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue being fixed or feature implemented
rimraf
module could not remove non-empty directory duringstart
, leading to:Error: ENOTEMPTY: directory not empty, rmdir '<userdir>/.dashmate/local_1/logs' Code: ENOTEMPTY
Partially fixes this issue
What was done?
fs.rmSync
insteadHow Has This Been Tested?
local setup
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only