Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drive): invalid query leads to internal error #259

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix(drive): invalid query leads to internal error #259

merged 1 commit into from
Feb 25, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Feb 25, 2022

Issue being fixed or feature implemented

Incorrectly constructed document queries are fatal Drive runtime and lead to crashes.

What was done?

  • Handle invalid query error type from RS Drive and respond with InvalidQueryError to user.

How Has This Been Tested?

With integration test

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.22.0 milestone Feb 25, 2022
@shumkov shumkov changed the title fix: invalid query errors are fatal fix(drive): invalid query errors are fatal Feb 25, 2022
@shumkov shumkov merged commit 03685a5 into v0.22-dev Feb 25, 2022
@shumkov shumkov deleted the invalid-query-errors branch February 25, 2022 09:07
@shumkov shumkov changed the title fix(drive): invalid query errors are fatal fix(drive): invalid query lead to internal errror Feb 25, 2022
@shumkov shumkov changed the title fix(drive): invalid query lead to internal errror fix(drive): invalid query leads to internal error Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawid-h jawid-h jawid-h approved these changes

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @shuplenkov @jawid-h