Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: build only necessary packages #27

Merged
merged 10 commits into from
Nov 10, 2021
Merged

build!: build only necessary packages #27

merged 10 commits into from
Nov 10, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 10, 2021

Issue being fixed or feature implemented

It doesn't make sense to build all packages for every package test. Also, we can use some build runners to do not build packages with no changes.

What was done?

  • Use ultra runner to run builds
  • Run builds only for necessary packages
  • Build browser versions only before packaging

How Has This Been Tested?

With CI

Breaking Changes

NPM build scripts are removed from Wallet lib, DPP and DAPI Client.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.x milestone Nov 10, 2021
strophy
strophy previously approved these changes Nov 10, 2021
@shumkov shumkov merged commit e051ef0 into master Nov 10, 2021
@shumkov shumkov deleted the optimize-build branch November 10, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants