fix(dapi): Identifier expects Buffer #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Nov 11, 2021
...dapi/test/unit/grpcServer/handlers/platform/getIdentityIdsByPublicKeyHashesHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Nov 11, 2021
.../test/integration/grpcServer/handlers/platform/waitForStateTransitionResultHandlerFactory.js
Outdated
Show resolved
Hide resolved
…itForStateTransitionResultHandlerFactory.js Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
shumkov
requested changes
Nov 11, 2021
packages/dapi/lib/externalApis/drive/fetchProofForStateTransitionFactory.js
Outdated
Show resolved
Hide resolved
added 2 commits
November 11, 2021 16:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
CBOR v.4 used to convert Uint8Array values to Buffer on encoding. Since we migrated to CBOR v.8, which doesnt convert them anymore, we need to convert them manually.
What was done?
Convert Uint8Array to Buffer
How Has This Been Tested?
With platform test suite
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only