Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix platform-test-suite-execution in browser environment #289

Merged
merged 38 commits into from
Mar 22, 2022

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Mar 10, 2022

Issue being fixed or feature implemented

Bring up platform-test-suite tests execution in browser (ChromeHeadless) environment

What was done?

  • Fix karma config for these tests
  • Fix merkle diff error that was caused by a lot of parallel requests
  • Fix serialize/deserialize error that was cause by different behaviour of closing GRPC stream in browser environment

How Has This Been Tested?

Locally on my laptop + CI

Breaking Changes

No breaking changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.22-dev to v0.23-dev March 21, 2022 15:26
@markin-io markin-io changed the base branch from v0.23-dev to master March 22, 2022 09:04
@pshenmic pshenmic requested review from markin-io and removed request for antouhou and shumkov March 22, 2022 11:23
@markin-io markin-io changed the base branch from master to v0.23-dev March 22, 2022 11:42
@markin-io markin-io force-pushed the platform-test-suite-browser-v22 branch from e5ae7a6 to 7354a11 Compare March 22, 2022 11:46
@markin-io markin-io changed the base branch from v0.23-dev to master March 22, 2022 11:46
@markin-io markin-io force-pushed the platform-test-suite-browser-v22 branch from 7354a11 to 76c54a9 Compare March 22, 2022 12:07
@pshenmic pshenmic added this to the v0.22.x milestone Mar 22, 2022
Copy link
Contributor

@markin-io markin-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@markin-io markin-io merged commit 6ca00a0 into master Mar 22, 2022
@markin-io markin-io deleted the platform-test-suite-browser-v22 branch March 22, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants