Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapi): fix parsing chainlocks received via ZMQ #296

Merged
merged 12 commits into from
Mar 22, 2022

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Mar 14, 2022

Issue being fixed or feature implemented

Fix parsing chainlocks coming from ZMQ listener

What was done?

Changed rawchainlock subscription to rawchainlocksig subscriptions and parse it as ChainLockSigMessage from dashcore-lib

How Has This Been Tested?

Running tests in dapi and platform test suite + debugging via console.log

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic changed the base branch from v0.22-dev to v0.23-dev March 14, 2022 05:13
@pshenmic pshenmic requested review from markin-io and removed request for antouhou March 14, 2022 05:13
@pshenmic pshenmic self-assigned this Mar 14, 2022
@pshenmic pshenmic added the bug Something isn't working label Mar 14, 2022
@pshenmic pshenmic added this to the v0.23.0 milestone Mar 14, 2022
@pshenmic pshenmic removed the bug Something isn't working label Mar 14, 2022
shumkov
shumkov previously approved these changes Mar 14, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io changed the base branch from v0.23-dev to master March 22, 2022 07:42
@pshenmic pshenmic changed the base branch from master to v0.23-dev March 22, 2022 08:39
Copy link
Contributor

@markin-io markin-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@markin-io markin-io merged commit ff1356b into v0.23-dev Mar 22, 2022
@markin-io markin-io deleted the fix/chainlocks-subscriptions branch March 22, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants