Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixes of sdk and platform test suite #309

Merged
merged 14 commits into from
Apr 5, 2022

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Mar 25, 2022

Issue being fixed or feature implemented

A set of fixes and optimizations facilitating platform-test-suite execution on testnet

What was done?

  • [Bugfix] Reworks transactions queue broadcasting. Instead of the instant lock, wallet relies on transaction info coming from the node (Fix for Mocha timeout of 650000ms exceeded.)

    This fix allows subsequent broadcastTransaction calls to pass once wallet received the information about previously sent TX

  • [Bugfix] Implements retryable stream for packages/platform-test-suite/test/functional/dapi/subscribeToBlockHeadersWithChainLocksHandlerFactory.spec.js

    This fix does not let test suite fail in case stream have been closed by the backend

  • [Bugfix] Increases TX metadata waiting interval from 180 to 360 seconds. Metadata needs more time to be delivered on a large-scale network.
    (Metadata waiting period for transaction ${transactionHash} timed out error)

  • [Optimization] Optimizes E2E wallet.spec.js for faster execution

How Has This Been Tested?

  • Executing platform-test-suite on testnet

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io changed the title [wip] test: fixes of sdk and platform test suite test: fixes of sdk and platform test suite Mar 28, 2022
@markin-io markin-io added this to the v0.23.0 milestone Mar 28, 2022
@markin-io markin-io requested a review from pshenmic March 28, 2022 14:13
shuplenkov
shuplenkov previously approved these changes Mar 28, 2022
Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

jawid-h
jawid-h previously approved these changes Mar 28, 2022
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glhf

@markin-io markin-io merged commit c13c9dc into master Apr 5, 2022
@markin-io markin-io deleted the fix/sdk-and-platform-test-suite-bugs branch April 5, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants