-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixes of sdk and platform test suite #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js to support retries
…ndlerFactory.spec.js
…lerFactory.spec.js to 10
…andlerFactory.spec.js after test completed
markin-io
changed the title
[wip] test: fixes of sdk and platform test suite
test: fixes of sdk and platform test suite
Mar 28, 2022
…thChainLocksHandlerFactory.spec.js
…ocksHandlerFactory.spec.js
shuplenkov
previously approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
jawid-h
previously approved these changes
Mar 28, 2022
pshenmic
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glhf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
A set of fixes and optimizations facilitating platform-test-suite execution on testnet
What was done?
[Bugfix] Reworks transactions queue broadcasting. Instead of the instant lock, wallet relies on transaction info coming from the node (Fix for
Mocha timeout of 650000ms exceeded.
)This fix allows subsequent broadcastTransaction calls to pass once wallet received the information about previously sent TX
[Bugfix] Implements retryable stream for
packages/platform-test-suite/test/functional/dapi/subscribeToBlockHeadersWithChainLocksHandlerFactory.spec.js
This fix does not let test suite fail in case stream have been closed by the backend
[Bugfix] Increases TX metadata waiting interval from 180 to 360 seconds. Metadata needs more time to be delivered on a large-scale network.
(
Metadata waiting period for transaction ${transactionHash} timed out
error)[Optimization] Optimizes E2E
wallet.spec.js
for faster executionHow Has This Been Tested?
platform-test-suite
on testnetBreaking Changes
Checklist:
For repository code-owners and collaborators only