Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable multiarch builds #316

Merged
merged 11 commits into from
Apr 5, 2022
Merged

ci: enable multiarch builds #316

merged 11 commits into from
Apr 5, 2022

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Mar 29, 2022

Issue being fixed or feature implemented

We need to support arm64 architecture for devs and running devnets. This PR enables multiarch builds in CI.

What was done?

Upstream images we depend on to build for each arch do not yet support arm64. Some projects are abandoned and no longer build. This PR rebases the images on which we depend to maintained forks, and PRs have been opened here, here and here to update the supported projects, and here and here to update our own components.. Until all of these projects have updated, we can use manually built images with multiarch support: strophy/grpc-web-common (source) and strophy/protoc (source). Let me know if you want to move these images under the dashpay org.

How Has This Been Tested?

In CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@strophy strophy merged commit 1f1f571 into dashpay:v0.23-dev Apr 5, 2022
@strophy strophy deleted the fix/dapi-grpc-arm64 branch April 5, 2022 09:50
@thephez thephez added this to the v0.23.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants