Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds balance and metadata information from registered identity #337

Merged
merged 2 commits into from
Apr 13, 2022
Merged

feat: adds balance and metadata information from registered identity #337

merged 2 commits into from
Apr 13, 2022

Conversation

Alex-Werner
Copy link
Contributor

@Alex-Werner Alex-Werner commented Apr 8, 2022 •
edited
Loading

Issue being fixed or feature implemented

When an identity is registered, the returned instance does not have any network information such as balance and metadata.
This PR will fetch after a registration the identity by its ID from the network in order to extend such information to the returned object by updating the balance value and adding the metadata property.

What was done?

  • feat: correctly setBalance and setMetadata of newly registered identity.

How Has This Been Tested?

  • Relying on test-suite

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner added this to the v0.23.0 milestone Apr 11, 2022
markin-io
markin-io approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@markin-io markin-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@Alex-Werner Alex-Werner merged commit c9f774a into v0.23-dev Apr 13, 2022
@Alex-Werner Alex-Werner deleted the feat/identity-register-balance branch April 13, 2022 22:24
markin-io pushed a commit that referenced this pull request Apr 25, 2022
@Alex-Werner @markin-io
feat: adds balance and metadata information from registered identity (#…
bf393ad 
…337)

* feat: adds balance and metadata information from registered identity

* fix: use setter method for identity
@markin-io markin-io mentioned this pull request Apr 25, 2022
Merged
5 tasks
markin-io pushed a commit that referenced this pull request Apr 27, 2022
@Alex-Werner @markin-io
feat: adds balance and metadata information from registered identity (#…
03299cc 
…337)

* feat: adds balance and metadata information from registered identity

* fix: use setter method for identity
@thephez thephez linked an issue Apr 27, 2022 that may be closed by this pull request
identities.register() returns identity with 0 credit balance #291
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markin-io markin-io markin-io approved these changes

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

identities.register() returns identity with 0 credit balance
2 participants
@Alex-Werner @markin-io