Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bench-suite): function benchmark and other improvements #344

Merged
merged 5 commits into from
Apr 18, 2022
Merged

feat(bench-suite): function benchmark and other improvements #344

merged 5 commits into from
Apr 18, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 12, 2022 •
edited
Loading

Issue being fixed or feature implemented

To proceed computational fee investigation bench suite required additional functionality. Also, some things didn't work properly.

What was done?

  • Fixed documents benchmark
  • Connect client only if benchmarks require it
  • Changed "mean" to "median"
  • Introduced function benchmark

How Has This Been Tested?

Running locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title chore: fee experiments feat: bench suite fixes and improvements Apr 14, 2022
@shumkov shumkov added this to the v0.23.0 milestone Apr 15, 2022
@shumkov shumkov marked this pull request as ready for review April 15, 2022 08:07
@shumkov shumkov requested a review from antouhou as a code owner April 15, 2022 08:07
@shumkov shumkov changed the title feat: bench suite fixes and improvements feat(bench-suite): function benchmarks and other Apr 15, 2022
@shumkov shumkov changed the title feat(bench-suite): function benchmarks and other feat(bench-suite): function benchmarks and other improvements Apr 15, 2022
@shumkov shumkov changed the title feat(bench-suite): function benchmarks and other improvements feat(bench-suite): function benchmark and other improvements Apr 15, 2022
@shumkov shumkov merged commit 6d7a66d into v0.23-dev Apr 18, 2022
@shumkov shumkov deleted the fee-experiments branch April 18, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawid-h jawid-h jawid-h approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @jawid-h