Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapi-client): retry doesn’t work with 502 errors #35

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

shuplenkov
Copy link
Collaborator

Issue being fixed or feature implemented

Dapi-client doesn't retry on 502 errors

What was done?

Fixed JsonTransport in Dapi-client

How Has This Been Tested?

Platform test suite

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.21.x milestone Nov 12, 2021
@shumkov shumkov changed the title fix(dapi-client): Dapi-client doesn't retry on 502 errors fix(dapi-client): retry doesn’t work with 502 errors Nov 12, 2021
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shuplenkov shuplenkov merged commit bfcd96e into master Nov 12, 2021
@shuplenkov shuplenkov deleted the fix-502-error branch November 12, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants