Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Core to v0.18.0.0-rc1 #351

Merged
merged 3 commits into from
Apr 21, 2022
Merged

chore: update Core to v0.18.0.0-rc1 #351

merged 3 commits into from
Apr 21, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 21, 2022 •
edited
Loading

Issue being fixed or feature implemented

Core v0.18.0.0-rc1 is finally getting ready for testing on testnet network. We need to update Platform v0.22, which is currently on testnet, to support the new version of Core.

What was done?

  • Updated dashcore-lib to support new quorum types
  • Updated dashmate to align with new RPC response formats
  • Remove the seed node from local network quorum formation process in dashmate
  • Fixed docker config migration for v0.22.0 in dashmate
  • Added config migration in dashmate

How Has This Been Tested?

Running locally + CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner April 21, 2022 12:05
@shumkov shumkov added this to the v0.22.x milestone Apr 21, 2022
shuplenkov
shuplenkov approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shumkov shumkov merged commit aa9d466 into master Apr 21, 2022
@shumkov shumkov deleted the update-core18 branch April 21, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @shuplenkov