Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): force option for group:stop command #36

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 12, 2021

Issue being fixed or feature implemented

When a node is running but some of the containers are stuck or restarting, there is not way to reset.

What was done?

  • Introduce force option to group:reset command to skip the "service running" check
  • Added the force flag to npm run reset

How Has This Been Tested?

Manually

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.x milestone Nov 12, 2021
@shumkov shumkov changed the base branch from v0.22-dev to master November 12, 2021 14:50
@shumkov shumkov merged commit c8c5a80 into master Nov 12, 2021
@shumkov shumkov deleted the force-stop branch November 12, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants