Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken QuorumEntry unserialization #366

Merged
merged 1 commit into from
Apr 29, 2022
Merged

fix: broken QuorumEntry unserialization #366

merged 1 commit into from
Apr 29, 2022

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Apr 29, 2022 •
edited
Loading

Issue being fixed or feature implemented

number too large to retain precision - use readVarintBN

What was done?

Updated dashcore-lib to 0.19.33

How Has This Been Tested?

WIth tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.22.x milestone Apr 29, 2022
shumkov
shumkov approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shuplenkov shuplenkov merged commit d6a4e52 into master Apr 29, 2022
@shuplenkov shuplenkov deleted the update-dashcore-lib branch April 29, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov