Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributing.md #37

Merged
merged 7 commits into from
Nov 15, 2021
Merged

docs: add contributing.md #37

merged 7 commits into from
Nov 15, 2021

Conversation

antouhou
Copy link
Collaborator

@antouhou antouhou commented Nov 12, 2021 •
edited
Loading

Issue being fixed or feature implemented

No contribution guide

What was done?

Add contribution guide

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • [] I have assigned this pull request to a milestone

jawid-h
jawid-h approved these changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me

@antouhou antouhou merged commit c9a585e into master Nov 15, 2021
@antouhou antouhou deleted the feat-contributing branch November 15, 2021 15:33
@shumkov shumkov added this to the v0.21.x milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawid-h jawid-h jawid-h approved these changes

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
4 participants
@antouhou @jawid-h @shumkov @strophy