Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate state transition fees using operations #376

Merged
merged 8 commits into from
May 3, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 3, 2022

Issue being fixed or feature implemented

Use new fee calculation formula to calculate state transition fees according to performed operations.

What was done?

  • Automatically create empty execution context for a state transition
  • Increased funding amount in SDK and tests
  • Introduce a new fee calculation function
  • Refactor fee operations
  • Use execution context and new calculation formula in validateStateTransitionFee function
  • Temporary does not reduce state transition fee from balance. Should be revert back when we collect operation from validate state and apply

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov marked this pull request as ready for review May 3, 2022 11:59
@shumkov shumkov requested a review from antouhou as a code owner May 3, 2022 11:59
@shumkov shumkov added this to the v0.23.0 milestone May 3, 2022
@shumkov shumkov requested a review from pshenmic May 3, 2022 12:40
jawid-h
jawid-h previously approved these changes May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants