feat!: Identity master key can be used only to update identity #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 10, 2022 14:29
shumkov
requested changes
May 11, 2022
packages/js-dpp/lib/stateTransition/AbstractStateTransitionIdentitySigned.js
Outdated
Show resolved
Hide resolved
...ges/js-dpp/lib/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
requested changes
May 12, 2022
packages/js-dpp/lib/stateTransition/errors/InvalidSignaturePublicKeySecurityLevelError.js
Outdated
Show resolved
Hide resolved
...ges/js-dpp/lib/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.js
Outdated
Show resolved
Hide resolved
...ges/js-dpp/lib/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.js
Outdated
Show resolved
Hide resolved
...ges/js-dpp/lib/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.js
Outdated
Show resolved
Hide resolved
added 2 commits
May 12, 2022 13:48
# Conflicts: # packages/js-dpp/lib/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.js
shumkov
requested changes
May 12, 2022
packages/js-dpp/lib/errors/consensus/signature/InvalidIdentityPublicKeyTypeError.js
Show resolved
Hide resolved
packages/js-dpp/lib/errors/consensus/signature/PublicKeyIsDisabledError.js
Outdated
Show resolved
Hide resolved
packages/js-dpp/lib/stateTransition/AbstractStateTransitionIdentitySigned.js
Show resolved
Hide resolved
shumkov
reviewed
May 12, 2022
packages/js-dpp/lib/stateTransition/AbstractStateTransitionIdentitySigned.js
Show resolved
Hide resolved
shumkov
requested changes
May 12, 2022
shumkov
reviewed
May 12, 2022
packages/js-dpp/lib/errors/consensus/signature/MasterPublicKeySecurityLevelIsNotAllowedError.js
Outdated
Show resolved
Hide resolved
…er-key-validation
…er-key-validation
…er-key-validation
shumkov
reviewed
May 13, 2022
added 2 commits
May 13, 2022 15:25
…er-key-validation
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
From security considerations, the master key should be used only for updating and disabling identity. For signing other state transitions we need to create another authorization key with security level - high.
What was done?
Changed state transition signature validation
How Has This Been Tested?
With tests
Breaking Changes
"High" security level keys must be used insted of "master"
Checklist:
For repository code-owners and collaborators only