Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dpp): calculate signature verification costs for fees #387

Merged
merged 4 commits into from
May 12, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 11, 2022

Issue being fixed or feature implemented

Verification of signatures is a pretty time-consuming operation, such as IO (read, write on disk). To cover verification with fees we need to collect those operations to state execution context as well.

What was done?

  • Added SignatureVerificationOperation
  • Collected the operations to State Transition Execution Context

How Has This Been Tested?

  • With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner May 11, 2022 12:49
@shuplenkov shuplenkov added this to the v0.23.0 milestone May 12, 2022
Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants