Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verifyChainLock was returning false instead of ResponseQuery #402

Merged
merged 2 commits into from
May 23, 2022
Merged

fix: verifyChainLock was returning false instead of ResponseQuery #402

merged 2 commits into from
May 23, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented May 23, 2022

Issue being fixed or feature implemented

verifyChainLock was returning false instead of ResponseQuery in case of Core not verifying ChainLock

What was done?

  • updated verifyChainLock
  • added more debug and trace logs

How Has This Been Tested?

devnet-mekhong

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jawid-h jawid-h merged commit 3f0f86d into master May 23, 2022
@jawid-h jawid-h deleted the fix/verifyChainLock branch May 23, 2022 15:27
@thephez thephez added this to the v0.22.x milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shumkov @thephez