Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CommitmentTxPayload#toBuffer method was using version instead of qfcVersion for serialization #410

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: CommitmentTxPayload#toBuffer method was using version instead of qfcVersion for serialization #410

merged 1 commit into from
May 26, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented May 25, 2022

Issue being fixed or feature implemented

CommitmentTxPayload#toBuffer method was using version instead of qfcVersion for serialization of quorumIndex

What was done?

  • updated dashcore-lib

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h merged commit 17a0fd5 into master May 26, 2022
@jawid-h jawid-h deleted the fix/commitment branch May 26, 2022 06:19
@thephez thephez added this to the v0.22.x milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shuplenkov @thephez