Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): docker images incorrectly tagged with v #413

Merged
merged 1 commit into from
May 26, 2022

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented May 26, 2022

Issue being fixed or feature implemented

Docker images built with the new workflow dispatch automation were incorrectly tagged with a v prefix

What was done?

  • Specify regex capturing group when parsing tag value

How Has This Been Tested?

Works with other tags ;)

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy changed the title fix: docker images incorrectly tagged with v ci(fix): docker images incorrectly tagged with v May 26, 2022
@strophy strophy added this to the v0.23.0 milestone May 26, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 6fd0318 into v0.23-dev May 26, 2022
@shumkov shumkov deleted the fix/docker-v-tag branch May 26, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants