fix: non-deterministic fees due to data contract cache #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
force-pushed
the
non-determinsitc-fees-data-contract-cache
branch
from
4625ab2
to
40eb9b9
Compare
shuplenkov
approved these changes
Jun 22, 2022
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Drive calculates different fees for a state transition depending on the data contract cache state. If a data contract is cached, then the read operation will be skipped. Since the data contract cache is not deterministic this could lead to a chain halt.
What was done?
StateRepository#removeDocumentnow accepts Data Contract to remove additional read operation.How Has This Been Tested?
With tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only