Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dashmate): update dashmate documentation #459

Merged
merged 3 commits into from
Jul 13, 2022
Merged

docs(dashmate): update dashmate documentation #459

merged 3 commits into from
Jul 13, 2022

Conversation

jaboski
Copy link
Contributor

@jaboski jaboski commented Jul 11, 2022

  • supported node.js versions
  • description for update command
  • changed usage examples to reflect command form from description

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jaboski
Update dashmate documentation about:
d5af45a 
- supported node.js versions
- description for update command
- changed usage examples to reflect command form from description
@jaboski jaboski requested a review from jawid-h July 11, 2022 09:46
thephez
thephez reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaboski! I had a small suggestion and also think the group command syntax doesn't need to be modified.

packages/dashmate/README.md Outdated Show resolved Hide resolved
packages/dashmate/README.md Outdated Show resolved Hide resolved
@thephez thephez changed the title Update dashmate documentation: docs(dashmate): update dashmate documentation Jul 11, 2022
thephez
thephez reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

shumkov
shumkov approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaboski jaboski merged commit 764808d into master Jul 13, 2022
@jaboski jaboski deleted the docs/update_dashmate_doc branch July 13, 2022 13:23
@thephez thephez added this to the v0.22.x milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thephez thephez thephez approved these changes

@shumkov shumkov shumkov approved these changes

@jawid-h jawid-h Awaiting requested review from jawid-h

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jaboski @shumkov @thephez