fix: infinite block production due to fees distribution #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotonoff
previously approved these changes
Aug 16, 2022
antouhou
approved these changes
Aug 18, 2022
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Storing block proposer to fee epoch leads to state update. Tenderdash triggers one more block if app hash is different to provide a signature for the previous block. Since this behaviour will be changed with same-block execution and we don't need signatures atm we can disable this logic for next-block execution as well.
What was done?
create-proof-block-rangeto0How Has This Been Tested?
With CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only