Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-suite): invalid transaction: missing inputs #494

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix(test-suite): invalid transaction: missing inputs #494

merged 1 commit into from
Aug 18, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 18, 2022

Issue being fixed or feature implemented

Some tests in test suite using dapi client directly instead of using Account#broadcastTransaction updated in #479.

What was done?

  • Use Account#broadcastTransaction

How Has This Been Tested?

Running tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 18, 2022
@shumkov shumkov requested a review from antouhou as a code owner August 18, 2022 18:21
@shumkov shumkov changed the title fix(test-suite): invalid transaction: Missing inputs fix(test-suite): invalid transaction: missing inputs Aug 18, 2022
@shumkov shumkov merged commit 2450194 into v0.23-dev Aug 18, 2022
@shumkov shumkov deleted the fix-input-missing branch August 18, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @shuplenkov