Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapi): getStatus errored if masternode is banned #496

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 19, 2022

Issue being fixed or feature implemented

TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined
    at new NodeError (node:internal/errors:372:5)
    at Function.from (node:buffer:323:9)
    at getStatusHandler (/platform/packages/dapi/lib/grpcServer/handlers/core/getStatusHandlerFactory.js:56:36)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async rpcMethodErrorHandler (/platform/packages/js-grpc-common/lib/server/error/wrapInErrorHandlerFactory.js:25:24) {
  code: 'ERR_INVALID_ARG_TYPE'
}

In case a masternode is banned

What was done?

  • Do not respond with proTxHash if masternode is banned
  • Propoerly parse livenet config option

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 19, 2022
@shumkov shumkov requested a review from antouhou as a code owner August 19, 2022 10:33
@shumkov shumkov merged commit cca0602 into v0.23-dev Aug 19, 2022
@shumkov shumkov deleted the fix-dapi-error branch August 19, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants