Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sdk): provide getTransactionHistory #5

Merged
merged 1 commit into from
Nov 3, 2021
Merged

docs(sdk): provide getTransactionHistory #5

merged 1 commit into from
Nov 3, 2021

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Nov 3, 2021 •
edited
Loading

Issue being fixed or feature implemented

This PR improve the documentation for getTransactionHistory method.

What was done?

  • doc: update Account.ts JSDoc
  • feat: remove async on getTransactionHistory
  • doc: update docsify with getTransactionHistory

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.22.0 milestone Nov 3, 2021
@shumkov shumkov merged commit 8575cb2 into v0.22-dev Nov 3, 2021
@shumkov shumkov deleted the doc/getTransactionHistory branch November 3, 2021 14:58
@shumkov shumkov changed the title docs: provide getTransactionHistory docs(sdk): provide getTransactionHistory Nov 3, 2021
thephez referenced this pull request in thephez/platform Nov 29, 2021
@jawid-h @Alex-Werner
docs: provide getTransactionHistory (#5)
4504282 
Co-authored-by: Alex Werner <Alex-Werner@users.noreply.github.com>
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@QuantumExplorer
Merge pull request #5 from dashevo/fix/driveTests6Jan
577c60a 
Fix tests for drive document insertion
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@qrayven
Merge pull request #5 from dashevo/add-git-workflows
8f87fce 
ci: introduce Rust workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov