chore: migrate from NPM to Yarn 3 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strophy
reviewed
Nov 24, 2021
.github/workflows/dapi-grpc.yml
Outdated
| @@ -15,6 +15,6 @@ on: | |||
| jobs: | |||
| dapi-tests: | |||
| name: Run DAPI gRPC tests | |||
| uses: dashevo/platform/.github/workflows/test.yml@master | |||
| uses: dashevo/platform/.github/workflows/test.yml@feat-yarn2 | |||
There was a problem hiding this comment.
I think this needs to change to master before merge?
There was a problem hiding this comment.
I think you can't rename it before merge, as master will have the correct file only after the merge? @shumkov
There was a problem hiding this comment.
Yeah, but before we need to make sure that tests are running, which is not a case atm.
antouhou
commented
Nov 24, 2021
.github/workflows/release.yml
Outdated
| @@ -49,7 +48,7 @@ jobs: | |||
| return (tag.includes('dev') ? `${major}.${minor}-dev` : 'latest'); | |||
|
|
|||
| - name: Publish NPM packages | |||
| run: npm publish --workspaces --access public --tag ${{ steps.tag.outputs.result }} | |||
| run: yarn npm publish --access public --tag ${{ steps.tag.outputs.result }} | |||
There was a problem hiding this comment.
Will this actually work?
There was a problem hiding this comment.
Honestly, I didn't try it yet :)
antouhou
commented
Nov 24, 2021
README.md
Outdated
| - Run `yarn setup` to install dependencies and configure and build all packages | ||
| - Run `yarn start` to start the local dev environment built from the sources | ||
| - Run `yarn test` to run the whole test suite (note that running tests requires a running node, | ||
| so be sure to call `npm start` first). Alternatively, you can run tests for a specific |
There was a problem hiding this comment.
Thank you. Changed all npm mentions.
antouhou
commented
Nov 24, 2021
# Conflicts: # package-lock.json # packages/dapi/package.json # packages/js-dapi-client/package.json # packages/js-dash-sdk/package.json # packages/js-dpp/package.json # packages/js-drive/package.json # packages/platform-test-suite/package.json # packages/wallet-lib/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
NPM has many downsides comparing with Yarn
What was done?
How Has This Been Tested?
Manually and with CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only